RATIS-1116. Add DataStreamType. #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also took this chance to split the newFactory method into newClientFactory and newServerFactory so that the client factory for DISABLE can be moved to the ratis-client module. |
runzhiwang
reviewed
Oct 29, 2020
ratis-common/src/main/java/org/apache/ratis/datastream/SupportedDataStreamType.java
Show resolved
Hide resolved
runzhiwang
reviewed
Oct 29, 2020
| .newDataStreamServerRpc(server, stateMachine, properties); | ||
| } | ||
|
|
||
| public DataStreamServerImpl(RaftServer server, StateMachine stateMachine, | ||
| RaftProperties properties, Parameters parameters){ | ||
| final SupportedDataStreamType type = RaftConfigKeys.DataStream.type(properties, LOG::info); | ||
|
|
||
| this.serverRpc = DataStreamServerFactory.cast(type.newFactory(parameters)) | ||
| this.serverRpc = DataStreamServerFactory.cast(type.newClientFactory(parameters)) |
There was a problem hiding this comment.
newClientFactory -> newServerFactory ?
There was a problem hiding this comment.
Good catch. It should be newServerFactory.
|
@szetszwo Thanks the patch. I have merged it. |
amaliujia
reviewed
Oct 29, 2020
| @@ -41,7 +42,8 @@ public void testDataStreamDisabled() throws Exception { | |||
| setupServer(); | |||
| setupClient(); | |||
| exception.expect(UnsupportedOperationException.class); | |||
| exception.expectMessage("org.apache.ratis.server.impl.DisabledDataStreamFactory$1 does not support streamAsync"); | |||
| exception.expectMessage(DisabledDataStreamClientFactory.class.getName() | |||
There was a problem hiding this comment.
+1 this is a better test.
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Feb 7, 2024
* RATIS-1116. Add DataStreamType. * Fix a bug and change the cast(..) method to newInstance(..).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/RATIS-1116