New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RATIS-1125. Fix TestDataStream #247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 thanks for fixing it.
@amaliujia Thanks the patch. @szetszwo Thanks for review. I have merged it. |
Oops, just find that the fix does not work since there are multiple servers. Each server should have its own map. Let me fix it in RATIS-1127. |
hmm I have thought about that. For current test setup it is ok. Because the data structure is For the multiple group change, I will need to update this test because in that change, servers will share the same group id so they cannot share the same map anymore. |
I see. It would work but it is confusing. Please put some comments on the code for work around like this. :) |
* RATIS.1125. Fix TestDataStream * fixup! add comment back
What changes were proposed in this pull request?
TestDataStream no long tests right state machine after RATIS-1124. It is because RaftServer uses its own map to keep state machine so the original state machines used to test server's writes no long work.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1125
How was this patch tested?
UT