RATIS-1109. Notify StateMachine on Configuration change #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szetszwo
approved these changes
Nov 3, 2020
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When Ratis receives a Configuration change request (SetConfiguration), the StateMachine is only notified of index update.
CompletableFuture applyLogToStateMachine(LogEntryProto next) {
if (!next.hasStateMachineLogEntry()) {
stateMachine.notifyIndexUpdate(next.getTerm(), next.getIndex());
} else if (next.hasStateMachineLogEntry()) {
......
This Jira aims to add a method in StateMachine interface to notify StateMachine about configuration change.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1109
How was this patch tested?
No unit test. Tested on Ozone cluster.