RATIS-1112. Ensure a node doesn't get reelected as a leader if it vol… #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…untarily steps down.
runzhiwang
reviewed
Nov 4, 2020
ratis-server/src/test/java/org/apache/ratis/server/impl/LeaderElectionTests.java
Show resolved
Hide resolved
runzhiwang
reviewed
Nov 4, 2020
| @@ -88,6 +93,20 @@ void stopRunning() { | |||
| this.isRunning = false; | |||
| } | |||
|
|
|||
| boolean lostMajorityHeartbeats() { | |||
There was a problem hiding this comment.
how about rename to isTimeoutSinceLostMajorityHeartbeats and return elapsed.compareTo(waitTime) >= 0?
There was a problem hiding this comment.
I got that you wanted to invert the boolean. However, "isTimeoutSinceLostMajorityHeartbeats" is hard to understand. So, let's keep "lostMajorityHeartbeats"? Or I can change it to ""lostMajorityHeartbeatsRecently".
There was a problem hiding this comment.
Okay, lostMajorityHeartbeatsRecently is better.
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Feb 7, 2024
…untarily steps down. (apache#252)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/RATIS-1112