RATIS-1144. Default disable datastream when start a MiniRaftCluster #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
amaliujia
reviewed
Nov 10, 2020
| @@ -96,6 +96,7 @@ private void testCloseStream(int leaderIndex, int numServers) throws Exception { | |||
| RaftPeerId peerId = RaftPeerId.valueOf("s" + i); | |||
| RaftProperties properties = new RaftProperties(); | |||
| NettyConfigKeys.DataStream.setPort(properties, NetUtils.createLocalServerAddress().getPort()); | |||
| RaftConfigKeys.DataStream.setType(properties, SupportedDataStreamType.NETTY); | |||
There was a problem hiding this comment.
This line is redundant. If you check line 61 this config is already be set.
There was a problem hiding this comment.
hmmm I see RaftProperties properties = new RaftProperties(); is not using the existing properties.
I will take a look and maybe fix this in my branch.
There was a problem hiding this comment.
@amaliujia It's a mock RaftServer, will not use properties set at line 61.
There was a problem hiding this comment.
O I see. thanks for clarification
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Default disable datastream when start a MiniRaftCluster, so that the other test no need to start data stream server, to make the CI run faster.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1144
How was this patch tested?
no need to add new ut.