Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-610. Add a builder for RaftClientReply. #283

Merged
merged 2 commits into from
Nov 18, 2020
Merged

RATIS-610. Add a builder for RaftClientReply. #283

merged 2 commits into from
Nov 18, 2020

Conversation

szetszwo
Copy link
Contributor

@runzhiwang runzhiwang closed this Nov 17, 2020
@runzhiwang runzhiwang reopened this Nov 17, 2020
Copy link
Contributor

@runzhiwang runzhiwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. waiting CI pass

@runzhiwang runzhiwang closed this Nov 18, 2020
@runzhiwang runzhiwang reopened this Nov 18, 2020
@runzhiwang runzhiwang closed this Nov 18, 2020
@runzhiwang runzhiwang reopened this Nov 18, 2020
@runzhiwang runzhiwang closed this Nov 18, 2020
@runzhiwang runzhiwang reopened this Nov 18, 2020
@runzhiwang
Copy link
Contributor

runzhiwang commented Nov 18, 2020

@szetszwo Seems failed ut related to this PR. Trigger CI 3 times, this ut always fail.
image

@runzhiwang runzhiwang closed this Nov 18, 2020
@runzhiwang runzhiwang reopened this Nov 18, 2020
@szetszwo
Copy link
Contributor Author

Thanks @runzhiwang . The test failure is related -- it uses a null server id so that the new assertion failed it.

@runzhiwang runzhiwang merged commit 6f49943 into apache:master Nov 18, 2020
symious pushed a commit to symious/ratis that referenced this pull request Feb 11, 2024
* RATIS-610. Add a builder for RaftClientReply.

* Fix testAsyncConfiguration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants