Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-667 Provide a visual for the LogService lifecycle #32

Closed

Conversation

joshelser
Copy link
Member

@cbaenziger had to tweak your PR a little. Does this look OK to you?

Co-authored-by: Josh Elser elserj@apache.org

@joshelser
Copy link
Member Author

Follow on for #31

@cbaenziger
Copy link
Contributor

Thanks! LGTM and works on my test with hugo serve. BTW should I add the dot command to the build.sh?

@joshelser
Copy link
Member Author

joshelser commented Aug 29, 2019

BTW should I add the dot command to the build.sh

Oh, that's not a bad idea (if the command exists). Let me try to add that.

@joshelser
Copy link
Member Author

Let me try to add that.

Not super feasible because it will clobber the ASF license header. I don't see an obvious way to re-add the license via the DOT file itself, so I'm just skipping that part.

But, there is some good improvements coming into build.sh as a result of me messing around here.

Co-authored-by: Josh Elser <elserj@apache.org>
@joshelser
Copy link
Member Author

Can you take a look again, @cbaenziger ?

Copy link
Contributor

@cbaenziger cbaenziger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but you may want one more set of double quotes.

build.sh Outdated Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
static/lifecycle.svg Show resolved Hide resolved
@joshelser
Copy link
Member Author

OK, 261e8a1 can regenerate the license header on OSX. Let me test on Linux too.

@joshelser
Copy link
Member Author

15ca39f fixes the issue of building on Linux. Going to squash/rebase this one as I think this will be good for what you were looking for :)

If the user doesn't have dot on the $PATH, we won't re-generate the SVG and everything else should continue as expected.

@joshelser joshelser closed this Aug 30, 2019
@joshelser
Copy link
Member Author

Merged!

@joshelser joshelser deleted the 667-lifecycle-fixing branch August 30, 2019 21:44
@ankitsinghal
Copy link
Contributor

oh great!! I didn't know that a framework like Graphviz exists. Visualization looks great. Thanks for working on this.
https://ratis.incubator.apache.org/logservice/lifecycle.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants