New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RATIS-667 Provide a visual for the LogService lifecycle #32
Conversation
Follow on for #31 |
Thanks! LGTM and works on my test with |
Oh, that's not a bad idea (if the command exists). Let me try to add that. |
Not super feasible because it will clobber the ASF license header. I don't see an obvious way to re-add the license via the DOT file itself, so I'm just skipping that part. But, there is some good improvements coming into |
ba7ea76
to
930fe48
Compare
Co-authored-by: Josh Elser <elserj@apache.org>
930fe48
to
171d0fb
Compare
Can you take a look again, @cbaenziger ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but you may want one more set of double quotes.
OK, 261e8a1 can regenerate the license header on OSX. Let me test on Linux too. |
15ca39f fixes the issue of building on Linux. Going to squash/rebase this one as I think this will be good for what you were looking for :) If the user doesn't have |
Merged! |
oh great!! I didn't know that a framework like Graphviz exists. Visualization looks great. Thanks for working on this. |
@cbaenziger had to tweak your PR a little. Does this look OK to you?
Co-authored-by: Josh Elser elserj@apache.org