Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RATIS-846: create simplest possible example, a replicated counter #60

Merged
merged 9 commits into from May 14, 2020
Merged

RATIS-846: create simplest possible example, a replicated counter #60

merged 9 commits into from May 14, 2020

Conversation

isahkemat
Copy link
Contributor

No description provided.

jnp
jnp reviewed Apr 16, 2020
View reviewed changes
Copy link
Contributor

@jnp jnp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a great patch and a very useful example. I very much like the idea of not having to run scripts for a basic example.

ratis-examples/README.md Outdated Show resolved Hide resolved
ratis-examples/README.md Show resolved Hide resolved
ratis-examples/src/main/java/org/apache/ratis/examples/counter/server/CounterServer.java Show resolved Hide resolved
@jnp
Copy link
Contributor

jnp commented May 3, 2020

Thanks for addressing comments. I am +1 for the patch.

@isahkemat
Copy link
Contributor Author

Any other comment or opionion?

bshashikant
bshashikant reviewed May 14, 2020
View reviewed changes
Copy link
Contributor

@bshashikant bshashikant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @esahekmat for the patch. The patch looks good.

Its a general recommendation to not use * imports. Can you please address this?
I am +1 on the patch otherwise.

@isahkemat
Copy link
Contributor Author

I have improved the PR and addressed all the * imports, current failure in build(unit tests) is not related to my work

bshashikant
bshashikant approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@bshashikant bshashikant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @esahekmat for the patch. The patch looks good.

Its a general recommendation to not use * imports. Can you please address this?
I am +1 on the patch otherwise.

@bshashikant bshashikant merged commit 800f2f1 into apache:master May 14, 2020
symious pushed a commit to symious/ratis that referenced this pull request Jan 26, 2024
@isahkemat @symious
RATIS-846: create simplest possible example, a replicated counter (ap…
4c79f18 
…ache#60)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnp jnp jnp left review comments

@bshashikant bshashikant bshashikant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@isahkemat @jnp @bshashikant