RATIS-833. Add metrics for raft log cache count and size in bytes #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @runzhiwang for working on this. We can potentially large no of closed segments in ratis pipeline lifecycle if log purging is not enabled. I am just thinking if it would be better to maintain the total segment size in memory instead of iterating over all to figure the size every-time to fetch the metric value. What do you think? |
|
@runzhiwang , can you please update the PR? |
|
@bshashikant updated |
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bshashikant Could you help review it ? Thank you very much.