RATIS-889. Fix TestRaftSnapshotWithGrpc and TestRaftSnapshotWithSimulatedRpc #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. +1 |
bshashikant
approved these changes
May 3, 2020
|
Thanks @runzhiwang for the review, and @bshashikant for reviewing and committing this. |
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix TestRaftSnapshotWithGrpc and TestRaftSnapshotWithSimulatedRpc:
StateMachineUpdaterunregisters metrics from the registry during stop, so the timer after restart is not the same instance as before. Thus, to verify that snapshot is taken during stop, we need to obtain the pre-stop timer.Also verify the metric right after snapshot file is created.
https://issues.apache.org/jira/browse/RATIS-889
How was this patch tested?
Executed
TestRaftSnapshot*multiple times. Also passed in CI:https://github.com/adoroszlai/incubator-ratis/runs/633049769