Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to the text on specifying name server list. #7

Closed
wants to merge 1 commit into from

Conversation

shroman
Copy link
Contributor

@shroman shroman commented Feb 10, 2017

No description provided.

@shroman
Copy link
Contributor Author

shroman commented Feb 10, 2017

@lizhanhui Some small changes. Just as a variant.

Also, I don't think HTTP endpoint should be mentioned unless there is a description on how a user can configure its own endpoint.

Another thing (not related to the docs) I thought is if a broker can be configured via a config file, why not to allow the same to producers/consumers?

@lizhanhui
Copy link
Contributor

lizhanhui commented Feb 10, 2017

"Also, I don't think HTTP endpoint should be mentioned unless there is a description on how a user can configure its own endpoint."

This, IMO, is the best way to configure name server addresses. Maybe we should add this endpoint to rocketmq-console project.

"Another thing (not related to the docs) I thought is if a broker can be configured via a config file, why not to allow the same to producers/consumers?"

Good point. I think we may make the client search configuration files in classpath as many projects do, say a default.conf file containing all default values and rocketmq.conf for application developer to override. This way, we can centralize all settings in one or two files.

@shroman
Copy link
Contributor Author

shroman commented Feb 10, 2017

"This, IMO, is the best way to configure name server addresses. Maybe we should add this endpoint to rocketmq-console project."

Yes, absolutely. But my point is the user have no idea what this endpoint is (I failed to access your default one. Not accessible outside of China?) or how to set up its own :)

👍 for rocketmq.conf. I would also get rid of environment variable to keep it simple.

@lizhanhui
Copy link
Contributor

@shroman We may create a JIRA ticket and thread in mailing list to follow this idea.

@shroman
Copy link
Contributor Author

shroman commented Feb 10, 2017

sure, I will create a JIRA issue so that this issue is not lost (https://issues.apache.org/jira/browse/ROCKETMQ-92).
And discussing in the ml is always good ;)

Basically, that is all from me. You can merge or close this PR.

@lizhanhui
Copy link
Contributor

I'll check and merge. It looks I do not have permission to close this PR.

asfgit pushed a commit that referenced this pull request Feb 10, 2017
@lizhanhui
Copy link
Contributor

This PR has been merged. @shroman you may close it.

@shroman shroman closed this Feb 10, 2017
asfgit pushed a commit that referenced this pull request Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants