Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RouteInfoManager.java #107

Closed
wants to merge 1 commit into from
Closed

Update RouteInfoManager.java #107

wants to merge 1 commit into from

Conversation

aCoder2013
Copy link
Contributor

fix spelling mistake

fix spelling mistake
@coveralls
Copy link

coveralls commented May 29, 2017

Coverage Status

Coverage decreased (-0.03%) to 38.636% when pulling a1be515 on aCoder2013:develop into 0fe9471 on apache:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 38.636% when pulling a1be515 on aCoder2013:develop into 0fe9471 on apache:develop.

@dongeforever
Copy link
Member

@aCoder2013 Thanks for your PR. You may want to follow the apache way, then attach the jira to the PR, as described in https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/

Copy link
Contributor

@shroman shroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aCoder2013 Please make the comment for this pull request more descriptive. Thank you!

@aCoder2013 aCoder2013 closed this May 31, 2017
@aCoder2013
Copy link
Contributor Author

@shroman @dongeforever hi , I've got the correct posture ,and submit a new PR, pls give it a look ,thank you ,#108,

pingww pushed a commit that referenced this pull request Aug 26, 2022
[ISSUE #106] fix fastjson update version to 1.2.83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants