[ROCKETMQ-91] Reduce lock granularity for putMessage to get better performance #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongeforever
changed the title
shroman
reviewed
Feb 16, 2017
| @@ -567,6 +577,11 @@ public PutMessageResult putMessage(final MessageExtBrokerInner msg) { | |||
| MappedFile unlockMappedFile = null; | |||
| MappedFile mappedFile = this.mappedFileQueue.getLastMappedFile(); | |||
|
|
|||
| //maybe need to wrap the exception | |||
There was a problem hiding this comment.
When encoding fails, let's notify a user with a PutMessageResult about the failure. There's nothing else we can do, I think.
shroman
reviewed
Feb 16, 2017
| @@ -1154,7 +1249,7 @@ public AppendMessageResult doAppend(final long fileFromOffset, final ByteBuffer | |||
|
|
|||
| if (propertiesLength > Short.MAX_VALUE) { | |||
| log.warn("putMessage message properties length too long. length={}", propertiesData.length); | |||
| return new AppendMessageResult(AppendMessageStatus.PROPERTIES_SIZE_EXCEEDED); | |||
| throw new RuntimeException("PROPERTIES_SIZE_EXCEEDED"); | |||
There was a problem hiding this comment.
By changing to this, PROPERTIES_SIZE_EXCEEDED won't be caught in the following switch.
|
LGTM |
1 similar comment
lizhanhui
pushed a commit
to lizhanhui/rocketmq
that referenced
this pull request
Dec 10, 2020
pingww
pushed a commit
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CommitLog putMessage has a lock as:
The logic inside the lock includes two main operations:
1 encode the message
2 write to the PageCache.
However, we can take the first operation(encode message) out from the lock to achieve better performance.
Tests
Env
Results
reduce before: about 14w TPS
reduce after: about 16w TPS
And if we annotate the store layer, only test the network performance, we got about 17W TPS.
The bottleneck now is in the network layer.
@zhouxinyu @vongosling @shroman please have a review.