Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCKETMQ-99] Add scripts for Windows #62

Closed
wants to merge 9 commits into from

Conversation

lizhanhui
Copy link
Contributor

Add scripts for windows where possible.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 31.626% when pulling ba4c596 on lizhanhui:ROCKETMQ-99 into 573b22c on apache:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 31.626% when pulling ba4c596 on lizhanhui:ROCKETMQ-99 into 573b22c on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 31.626% when pulling ba4c596 on lizhanhui:ROCKETMQ-99 into 573b22c on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 31.538% when pulling ba4c596 on lizhanhui:ROCKETMQ-99 into 573b22c on apache:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 31.538% when pulling ba4c596 on lizhanhui:ROCKETMQ-99 into 573b22c on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 31.538% when pulling ba4c596 on lizhanhui:ROCKETMQ-99 into 573b22c on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 31.561% when pulling ba4c596 on lizhanhui:ROCKETMQ-99 into 573b22c on apache:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 31.561% when pulling ba4c596 on lizhanhui:ROCKETMQ-99 into 573b22c on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 31.561% when pulling ba4c596 on lizhanhui:ROCKETMQ-99 into 573b22c on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 31.529% when pulling ba4c596 on lizhanhui:ROCKETMQ-99 into 573b22c on apache:master.

1 similar comment
@coveralls
Copy link

coveralls commented Feb 15, 2017

Coverage Status

Coverage increased (+0.009%) to 31.529% when pulling ba4c596 on lizhanhui:ROCKETMQ-99 into 573b22c on apache:master.

Copy link
Member

@zhouxinyu zhouxinyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please @vongosling help review.

@vongosling
Copy link
Member

@lizhanhui Cool. Did you check the commits, letting all passed in at least 2 windows environment ?

@lizhanhui
Copy link
Contributor Author

@vongosling I plan to install a Windows XP on a virtual machine if there is no feedback from community. Actually, I am hoping someone may test this PR on Windows 10 which covers majority of windows users.

@vongosling
Copy link
Member

I am hoping someone may test this PR on Windows 10 which covers majority of windows users.
Show all checks

Yep agreed.

asfgit pushed a commit that referenced this pull request Feb 28, 2017
@vongosling
Copy link
Member

@lizhanhui Done for dev. branch ~ Could you close this PR?

@lizhanhui
Copy link
Contributor Author

All right.

@lizhanhui lizhanhui closed this Mar 23, 2017
asfgit pushed a commit that referenced this pull request Jun 6, 2017
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
pingww pushed a commit that referenced this pull request Aug 26, 2022
Co-authored-by: AhaThinking <ahathinking@SK-20211027RHLU.mioffice.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants