-
Notifications
You must be signed in to change notification settings - Fork 11.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCKETMQ-99] Add scripts for Windows #62
Conversation
2 similar comments
2 similar comments
2 similar comments
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please @vongosling help review.
@lizhanhui Cool. Did you check the commits, letting all passed in at least 2 windows environment ? |
@vongosling I plan to install a Windows XP on a virtual machine if there is no feedback from community. Actually, I am hoping someone may test this PR on Windows 10 which covers majority of windows users. |
I am hoping someone may test this PR on Windows 10 which covers majority of windows users. Yep agreed. |
@lizhanhui Done for dev. branch ~ Could you close this PR? |
All right. |
Co-authored-by: AhaThinking <ahathinking@SK-20211027RHLU.mioffice.cn>
Add scripts for windows where possible.