RYA-284: updated to support bloom filter #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Can you submit another PR with only the required changes? There are a lot of whitespace and final changes. Normally I would power through this, but the github "ignore whitespace" hack doesn't seem to be working. |
amihalik
reviewed
Jun 8, 2017
| protected void fillScanner(ScannerBase scanner, RyaURI context, String qualifier, Long ttl, Long currentTime, | ||
| TripleRowRegex tripleRowRegex, RdfCloudTripleStoreConfiguration conf) throws IOException { | ||
| if (context != null && qualifier != null) { | ||
| private static Text createText(final byte[] data, final RyaType ryaType) throws RyaTypeResolverException { |
There was a problem hiding this comment.
"appendType" would be a better name for this method.
There was a problem hiding this comment.
Okay. Will put up a new PR with the new method name.
amihalik
reviewed
Jun 8, 2017
| Range range = new Range(new Text(byteRange.getStart()), new Text(byteRange.getEnd())); | ||
| if ((stmt.getSubject() != null) && (stmt.getPredicate() != null) && (stmt.getObject() != null)) { | ||
| range = Range.exact(createText(byteRange.getStart(), stmt.getObject())); |
There was a problem hiding this comment.
does byteRange.getStart() ever have the type appended to it at this point? (if so, then this won't work)
There was a problem hiding this comment.
that's what createText (current method name) is supposed to do.
|
Closed and will submit a new PR as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated dao/accumulo.rya to support the use of bloom filter
Tests
no new tests
Links
JIRA -> RYA-284
People To Review
@amihalik