Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RYA-333 Added "-P coverage" to generate code coverage reports. #241

Closed
wants to merge 2 commits into from

Conversation

jdasch
Copy link
Contributor

@jdasch jdasch commented Oct 10, 2017

Description

Added -P coverage for generating a code-coverage report
removed unnecessary version override of the mycila license plugin
removed unnecessary argLine for the maven-surefire-plugin

Tests

N/A

Links

Jira RYA-333

Checklist

  • Code Review
  • Squash Commits

People To Review

@meiercaleb
@isper3at
@kchilton2


<!-- Enable this profile to generate a Code Coverage report with jacoco "mvn ... -P coverage" -->
<profile>
<id>coverage</id>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have a profile? Why not just run it as default as part of the build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I view code coverage as value added, especially since we are not enforcing a minimum coverage policy right now. There is a minor cost associated with running it and it is conceivable that you might not want to run it as part of the release build.

@jdasch
Copy link
Contributor Author

jdasch commented Oct 10, 2017

asfbot build

@amihalik
Copy link
Contributor

I tried creating a build on b.a.o with the coverage profile enabled and "record jacoco report" plug-in enabled.

You can check on it's progress here: https://builds.apache.org/job/incubator-rya-master-with-optionals-with-coverage/

I'll roll these changes into the master builds once this PR is pulled in.

@jdasch jdasch changed the title RYA-333 Added "-P coverage" to generate code coverage reports. [WIP] RYA-333 Added "-P coverage" to generate code coverage reports. Oct 10, 2017
@jdasch jdasch changed the title [WIP] RYA-333 Added "-P coverage" to generate code coverage reports. RYA-333 Added "-P coverage" to generate code coverage reports. Oct 12, 2017
@asfgit
Copy link

asfgit commented Oct 12, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/528/

@asfgit asfgit closed this in 244b870 Oct 12, 2017
@jdasch jdasch deleted the RYA-333 branch October 13, 2017 18:06
ejwhite922 pushed a commit to ejwhite922/incubator-rya that referenced this pull request Nov 8, 2017
DLotts pushed a commit to DLotts/rya that referenced this pull request Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants