New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RYA-333 Added "-P coverage" to generate code coverage reports. #241
Conversation
|
||
<!-- Enable this profile to generate a Code Coverage report with jacoco "mvn ... -P coverage" --> | ||
<profile> | ||
<id>coverage</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have a profile? Why not just run it as default as part of the build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I view code coverage as value added, especially since we are not enforcing a minimum coverage policy right now. There is a minor cost associated with running it and it is conceivable that you might not want to run it as part of the release build.
Refer to this link for build results (access rights to CI server needed): Failed Tests: 1incubator-rya-master-with-optionals-pull-requests/org.apache.rya:rya.sail: 1 |
asfbot build |
I tried creating a build on b.a.o with the coverage profile enabled and "record jacoco report" plug-in enabled. You can check on it's progress here: https://builds.apache.org/job/incubator-rya-master-with-optionals-with-coverage/ I'll roll these changes into the master builds once this PR is pulled in. |
Refer to this link for build results (access rights to CI server needed): Failed Tests: 1incubator-rya-master-with-optionals-pull-requests/org.apache.rya:rya.sail: 1 |
- removed the maven-surefire-plugin's -Dfile.encoding=UTF-8 argLine
Refer to this link for build results (access rights to CI server needed): |
Description
Added -P coverage for generating a code-coverage report
removed unnecessary version override of the mycila license plugin
removed unnecessary argLine for the maven-surefire-plugin
Tests
N/A
Links
Jira RYA-333
Checklist
People To Review
@meiercaleb
@isper3at
@kchilton2