[RYA-405] Migrate from Sesame to rdf4j libs #245

jomach · 2017-10-18T14:55:38Z

Description

What Changed?
[Brief Description of what changed]

Tests

Coverage?
Hi Guys, we are giving a test drive on this rya and I updated the project to use a new libs.

Can someone check this ? Important would be to review stuff:

like new RDFFORMAT(... not sure if I have done this right.
and the map reduce data loads.

[Description of what tests were written]

Links

Jira

Checklist

Code Review
Squash Commits

People To Reivew

[Add those who should review this]

Initial migration to rdf4j

asfgit · 2017-10-18T14:55:40Z

Can one of the admins verify this patch?

amihalik · 2017-10-18T15:02:30Z

ok to test

asfgit · 2017-10-18T15:10:24Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/531/

Fixing compile errors

More Compile fixing errors

isper3at · 2017-10-19T16:40:51Z

you have 2 commits that have the same message with different hashes, can you clean that up and get this to build?

jomach · 2017-10-19T17:11:42Z

@isper3at Sorry I cannot undo that. This is taking a lot more effort that I initially thought because of the geoindexing. I'm thinking about closing this PR and open a new one when I have this compiling.
I think we should create a new branch for this. What do you think ?

isper3at · 2017-10-19T17:16:58Z

I'm checking out your commit now to see why geoindexing would give you grief.
I don't think a new PR is required, we can just not do the review until after it builds, change the title to start with [WIP]

jomach · 2017-10-19T17:39:59Z

So I found why. I tested the minicluster in a new project alone and it works fine. Seems to be the Pom.xml I will push my other commits that are local until now

More Compile fixing errors

isper3at · 2017-10-19T17:45:00Z

I'm still confused as to why your commits are overlapping so much and why you can't squash the commits.

jomach · 2017-10-19T17:48:06Z

Because The changes are not trivial...

ejwhite922

Looks good. The review became a bit unwieldy with all the interface method access level changes added on top of the Sesame lib update.

ejwhite922 · 2017-10-19T14:53:05Z

common/rya.api/src/main/java/org/apache/rya/api/RdfCloudTripleStoreConfigurationBuilder.java

@@ -123,7 +123,7 @@ public B setDisplayQueryPlan(boolean displayPlan) {

    /**
     * 
-     * @return {@link RdfCloudTripleStoreConfiguration} object with specified parameters set
+     * @return {@link RdfCloudTripleStoreUtils} object with specified parameters set


The original javadocs were right.

ejwhite922 · 2017-10-19T14:53:27Z

common/rya.api/src/main/java/org/apache/rya/api/RdfCloudTripleStoreConfigurationBuilder.java

@@ -88,8 +88,8 @@ public B setAuths(String auths) {
     *            - visibilities assigned to any triples inserted into Rya
     * @return B - concrete builder class for chaining method invocations
     */
-    public B setVisibilities(String visibilites) {
-        this.visibilities = visibilites;
+    public B setVisibilities(String visibilities) {


ejwhite922 · 2017-10-19T15:10:14Z

common/rya.api/src/main/java/org/apache/rya/api/domain/RyaType.java

-            return false;
-        }
-        return true;
+        return dataType != null ? dataType.equals(ryaType.dataType) : ryaType.dataType == null;


While in here, I'd just have the equals() method use an EqualsBuilder so all the inline-if's that were here before can be removed:

public boolean equals(final Object o) { if (o == this) { return true; } if (o == null || !(o instanceof RyaType)) { return false; } final RyaType other = (RyaType) o; final EqualsBuilder builder = new EqualsBuilder() .append(getData(), other.getData()) .append(getDataType(), other.getDataType()); return builder.isEquals(); }

ejwhite922 · 2017-10-19T15:15:00Z

common/rya.api/src/main/java/org/apache/rya/api/domain/StatementMetadata.java


 public class StatementMetadata {

    private static Gson gson = new GsonBuilder().enableComplexMapKeySerialization()
-    .registerTypeHierarchyAdapter(RyaType.class, new RyaTypeAdapter()).create();;


ejwhite922 · 2017-10-19T17:21:21Z

pom.xml

        <!--Cannot upgrade to openrdf.sesame 2.7.6 until RYA-9 is resolved -->

-        <accumulo.version>1.6.4</accumulo.version> <!-- Newest: 1.7.0 -->
-        <hadoop.version>2.5.0</hadoop.version> <!-- Newest: 2.7.1 -->
+        <accumulo.version>1.8.1</accumulo.version> <!-- Newest: 1.7.0 -->


I'd leave these dependency versions as they were if possible

ejwhite922 · 2017-10-19T17:39:21Z

common/rya.api/src/main/java/org/apache/rya/api/persist/index/RyaSecondaryIndexer.java

 import org.apache.rya.api.domain.RyaStatement;
 import org.apache.rya.api.domain.RyaURI;
+import org.eclipse.rdf4j.model.IRI;

 public interface RyaSecondaryIndexer extends Closeable, Flushable, Configurable {


Switching all these interface methods to default access level is making the review rather large (which will still be public anyways).

jomach · 2017-10-19T17:54:32Z

Can we create tasks for each point that need change ?

isper3at · 2017-10-19T18:00:03Z

the complexity of the changes shouldn't matter to git, I was able to squash all the commits into 1 with no conflicts. I am still seeing compile errors in GeoFunctionsIT

isper3at · 2017-10-19T18:00:58Z

sure, something of this scale, it would be nice to have it split up into smaller commits. Do you not have create issue rights on Jira? If not, let me know which tickets need making and I'll link you to them all,

edit
just saw @ejwhite922 comments, yours was probably to those

isper3at · 2017-10-19T18:10:50Z

common/rya.api/src/main/java/org/apache/rya/api/resolver/RyaTripleContext.java

-import org.apache.rya.api.query.strategy.wholerow.OspWholeRowTriplePatternStrategy;
-import org.apache.rya.api.query.strategy.wholerow.PoWholeRowTriplePatternStrategy;
-import org.apache.rya.api.query.strategy.wholerow.SpoWholeRowTriplePatternStrategy;
+import org.apache.rya.api.query.strategy.wholerow.*;


don't use wildcard imports

isper3at · 2017-10-19T18:11:07Z

common/rya.api/src/main/java/org/apache/rya/api/resolver/RyaTypeResolver.java


 /**
 * Date: 7/16/12
 * Time: 12:08 PM
 */
 public interface RyaTypeResolver {
-    public byte[] serialize(RyaType ryaType) throws RyaTypeResolverException;
-    public byte[][] serializeType(RyaType ryaType) throws RyaTypeResolverException;
+    byte[] serialize(RyaType ryaType) throws RyaTypeResolverException;


why are you changing the access level to a lot of these interfaces?

isper3at · 2017-10-19T18:12:18Z

...n/rya.api/src/test/java/org/apache/rya/api/query/strategy/wholerow/MockRdfConfiguration.java

@@ -22,7 +22,7 @@

 import org.apache.rya.api.RdfCloudTripleStoreConfiguration;

-public class MockRdfCloudConfiguration extends RdfCloudTripleStoreConfiguration {
+public class MockRdfConfiguration extends RdfCloudTripleStoreConfiguration {


why the rename?

isper3at · 2017-10-19T18:14:51Z

extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloCreatePeriodicPCJ.java


-import com.google.common.base.Optional;
+import static java.util.Objects.requireNonNull;


nit: put the static imports above the non-static imports

isper3at · 2017-10-19T18:15:01Z

extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloDeletePeriodicPCJ.java

 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

-import com.google.common.base.Optional;
+import static java.util.Objects.requireNonNull;


isper3at · 2017-10-19T18:15:21Z

...as/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloExecuteSparqlQuery.java


-import edu.umd.cs.findbugs.annotations.DefaultAnnotation;
-import edu.umd.cs.findbugs.annotations.NonNull;
+import static java.util.Objects.requireNonNull;


isper3at · 2017-10-19T18:17:55Z

...src/main/java/org/apache/rya/indexing/IndexPlanValidator/ValidIndexCombinationGenerator.java

-					return true;
-				}
+				} else
+                    return !isEmpty;


do not remove curly braces around the else

This was my idea. Sorry

asfgit · 2017-10-19T19:13:31Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/533/

Build result: FAILURE

[...truncated 2.28 MB...][INFO] Apache Rya Spark Support ........................... SKIPPED[INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 01:08 h[INFO] Finished at: 2017-10-19T19:12:03+00:00[INFO] Final Memory: 230M/3357M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (check-licenses) on project rya.pcj.functions.geo: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/rya.pcj.fluo/rya.pcj.functions.geo/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :rya.pcj.functions.geochannel stoppedSetting status of 0b13fdb to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/533/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing

Try to fix DocumentIndexIntersectingIteratorTest

jomach · 2017-10-20T06:51:20Z

@asfgit @isper3at Can someone Help me with DocumentIndexIntersectingIteratorTest ? It seems not to work and I don't know why. Just make a PR against my fork.

Create AccumuloMiniCluster to Run Tests

asfgit · 2017-10-20T12:22:57Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/535/

Build result: ABORTED

[...truncated 1.27 MB...]2017-10-20 10:02:24 INFO EmbeddedMongoFactory:42 - 2017-10-20T10:02:24.994+0000 I COMMAND [conn2] dropDatabase testDB finished[mongod output] 2017-10-20 10:02:25 INFO EmbeddedMongoFactory:42 - 2017-10-20T10:02:25.796+0000 I COMMAND [conn2] command testDB.entity-types command: insert { insert: "entity-types", ordered: true, documents: [ { _id: "urn:person", propertyNames: [ "urn:name", "urn:age", "urn:eye" ] } ] } ninserted:1 keyUpdates:0 writeConflicts:0 numYields:0 reslen:40 locks:{ Global: { acquireCount: { r: 2, w: 2 } }, Database: { acquireCount: { w: 1, W: 1 } }, Collection: { acquireCount: { W: 1 } } } protocol:op_query 768ms[mongod output] 2017-10-20 10:02:26 INFO EmbeddedMongoFactory:42 - 2017-10-20T10:02:26.007+0000 I COMMAND [conn2] command testDB.entity-entities command: insert { insert: "entity-entities", ordered: true, documents: [ { _id: "urn:SSN:111-11-1111", explicitTypeIds: [ "urn:person" ], properties: { urn:person: { urn:eye: { dataType: "http://www.w3.org/2001/XMLSchema#string", value: "blue" }, urn:name: { dataType: "http://www.w3.org/2001/XMLSchema#string", value: "bob" }, urn:age: { dataType: "http://www.w3.org/2001/XMLSchema#string", value: "25" } } }, version: 0, smartUri: "urn://SSN:111-11-1111?ryaTypes=urn%3A%2F%2FentityTypeMap%3Furn%253Aperson%3Dperson&person.eye=blue&person.name=bob&person.age=25" } ] } ninserted:1 keyUpdates:0 writeConflicts:0 numYields:0 reslen:40 locks:{ Global: { acquireCount: { r: 2, w: 2 } }, Database: { acquireCount: { w: 1, W: 1 } }, Collection: { acquireCount: { w: 1, W: 1 } } } protocol:op_query 203ms[mongod output] 2017-10-20 10:02:26 INFO EmbeddedMongoFactory:42 - 2017-10-20T10:02:26.053+0000 I COMMAND [conn2] dropDatabase testDB starting[mongod output] 2017-10-20 10:02:26 INFO EmbeddedMongoFactory:42 - 2017-10-20T10:02:26.054+0000 I COMMAND [conn2] dropDatabase testDB finished[mongod output] 2017-10-20 10:02:26 INFO EmbeddedMongoFactory:42 - 2017-10-20T10:02:26.300+0000 I COMMAND [conn2] command testDB.entity-types command: insert { insert: "entity-types", ordered: true, documents: [ { _id: "urn:person", propertyNames: [ "urn:name", "urn:age", "urn:eye" ] } ] } ninserted:1 keyUpdates:0 writeConflicts:0 numYields:0 reslen:40 locks:{ Global: { acquireCount: { r: 2, w: 2 } }, Database: { acquireCount: { w: 1, W: 1 } }, Collection: { acquireCount: { W: 1 } } } protocol:op_query 214ms[mongod output] 2017-10-20 10:02:26 INFO EmbeddedMongoFactory:42 - 2017-10-20T10:02:26.544+0000 I COMMAND [conn2] command testDB.entity-entities command: insert { insert: "entity-entities", ordered: true, documents: [ { _id: "urn:SSN:111-11-1111", explicitTypeIds: [ "urn:person" ], properties: { urn:person: { urn:eye: { dataType: "http://www.w3.org/2001/XMLSchema#string", value: "blue" }, urn:name: { dataType: "http://www.w3.org/2001/XMLSchema#string", value: "bob" }, urn:age: { dataType: "http://www.w3.org/2001/XMLSchema#string", value: "25" } } }, version: 0, smartUri: "urn://SSN:111-11-1111?ryaTypes=urn%3A%2F%2FentityTypeMap%3Furn%253Aperson%3Dperson&person.eye=blue&person.name=bob&person.age=25" } ] } ninserted:1 keyUpdates:0 writeConflicts:0 numYields:0 reslen:40 locks:{ Global: { acquireCount: { r: 2, w: 2 } }, Database: { acquireCount: { w: 1, W: 1 } }, Collection: { acquireCount: { w: 1, W: 1 } } } protocol:op_query 234ms[mongod output] 2017-10-20 10:02:26 INFO EmbeddedMongoFactory:42 - 2017-10-20T10:02:26.552+0000 I COMMAND [conn2] dropDatabase testDB starting[mongod output] 2017-10-20 10:02:26 INFO EmbeddedMongoFactory:42 - 2017-10-20T10:02:26.552+0000 I COMMAND [conn2] dropDatabase testDB finished[mongod output] 2017-10-20 10:02:26 INFO EmbeddedMongoFactory:42 - 2017-10-20T10:02:26.796+0000 I COMMAND [conn2] command testDB.entity-types command: insert { insert: "entity-types", ordered: true, documents: [ { _id: "urn:person", propertyNames: [ "urn:name", "urn:age", "urn:eye" ] } ] } ninserted:1 keyUpdates:0 writeConflicts:0 numYields:0 reslen:40 locks:{ Global: { acquireCount: { r: 2, w: 2 } }, Database: { acquireCount: { w: 1, W: 1 } }, Collection: { acquireCount: { W: 1 } } } protocol:op_query 208ms[mongod output] 2017-10-20 10:02:27 INFO EmbeddedMongoFactory:42 - 2017-10-20T10:02:27.047+0000 I COMMAND [conn2] command testDB.entity-entities command: insert { insert: "entity-entities", ordered: true, documents: [ { _id: "urn:SSN:111-11-1111", explicitTypeIds: [ "urn:person" ], properties: { urn:person: { urn:eye: { dataType: "http://www.w3.org/2001/XMLSchema#string", value: "blue" }, urn:name: { dataType: "http://www.w3.org/2001/XMLSchema#string", value: "bob" }, urn:age: { dataType: "http://www.w3.org/2001/XMLSchema#string", value: "25" } } }, version: 0, smartUri: "urn://SSN:111-11-1111?ryaTypes=urn%3A%2F%2FentityTypeMap%3Furn%253Aperson%3Dperson&person.eye=blue&person.name=bob&person.age=25" } ] } ninserted:1 keyUpdates:0 writeConflicts:0 numYields:0 reslen:40 locks:{ Global: { acquireCount: { r: 2, w: 2 } }, Database: { acquireCount: { w: 1, W: 1 } }, Collection: { acquireCount: { w: 1, W: 1 } } } protocol:op_query 244ms[mongod output] 2017-10-20 10:02:27 INFO EmbeddedMongoFactory:42 - 2017-10-20T10:02:27.645+0000 I COMMAND [conn2] dropDatabase testDB starting[mongod output] 2017-10-20 10:02:27 INFO EmbeddedMongoFactory:42 - 2017-10-20T10:02:27.646+0000 I COMMAND [conn2] dropDatabase testDB finished[mongod output] 2017-10-20 10:02:27 INFO EmbeddedMongoFactory:42 - 2017-10-20T10:02:27.922+0000 I COMMAND [conn2] command testDB.entity-types command: insert { insert: "entity-types", ordered: true, documents: [ { _id: "urn:person", propertyNames: [ "urn:name", "urn:age", "urn:eye" ] } ] } ninserted:1 keyUpdates:0 writeConflicts:0 numYields:0 reslen:40 locks:{ Global: { acquireCount: { r: 2, w: 2 } }, Database: { acquireCount: { w: 1, W: 1 } }, Collection: { acquireCount: { W: 1 } } } protocol:op_query 240ms[mongod output] 2017-10-20 10:02:28 INFO EmbeddedMongoFactory:42 - 2017-10-20T10:02:28.140+0000 I COMMAND [conn2] command testDB.entity-entities command: insert { insert: "entity-entities", ordered: true, documents: [ { _id: "urn:SSN:111-11-1111", explicitTypeIds: [ "urn:person" ], properties: { urn:person: { urn:eye: { dataType: "http://www.w3.org/2001/XMLSchema#string", value: "blue" }, urn:name: { dataType: "http://www.w3.org/2001/XMLSchema#string", value: "bob" }, urn:age: { dataType: "http://www.w3.org/2001/XMLSchema#string", value: "25" } } }, version: 0, smartUri: "urn://SSN:111-11-1111?ryaTypes=urn%3A%2F%2FentityTypeMap%3Furn%253Aperson%3Dperson&person.eye=blue&person.name=bob&person.age=25" } ] } ninserted:1 keyUpdates:0 writeConflicts:0 numYields:0 reslen:40 locks:{ Global: { acquireCount: { r: 2, w: 2 } }, Database: { acquireCount: { w: 1, W: 1 } }, Collection: { acquireCount: { w: 1, W: 1 } } } protocol:op_query 211ms[mongod output] 2017-10-20 10:02:28 INFO EmbeddedMongoFactory:42 - 2017-10-20T10:02:28.434+0000 I COMMAND [conn2] dropDatabase testDB starting[mongod output] 2017-10-20 10:02:28 INFO EmbeddedMongoFactory:42 - 2017-10-20T10:02:28.435+0000 I COMMAND [conn2] dropDatabase testDB finished[mongod output] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.944 sec - in org.apache.rya.indexing.mongo.MongoEntityIndexTestBuild timed out (after 180 minutes). Marking the build as aborted.Build was abortedchannel stoppedSetting status of 38c1c0c to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/535/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing

ejwhite922

DocumentIndexIntersectingIteratorTest is failing from Accumulo being updated. Switch that dependency back to the original version and all the other dependency versions too. Besides org.eclipse.rdf4j, only Lucene appears to need its version updated in the main pom since it's a dependency of RDF4J. The latest Lucene changed its artifact ID from lucene-analyzers to lucene-analyzers-common though.

jomach · 2017-10-24T08:01:17Z

so rya is forced to run on Accumulo 1.6.1 ?

ejwhite922

No, but 1.6.4 is what we currently support and have tested so far. Updating the Accumulo libraries is outside the scope of this ticket and appears to introduce new problems. We can update Accumulo under a separate ticket if there is a desire for that from others.

jomach · 2017-10-24T21:04:11Z

Ok. Will try that

-Fixing stuff

jomach · 2017-11-05T11:47:13Z

nice work @ejwhite922 looks better now.

* RYA-405 Fixing more imports * RYA-405 Fixes for integration tests * RYA-405 Fixed license mixed in imports

asfgit · 2017-11-09T18:54:27Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/549/

ejwhite922

Some notes on what's changed and what to look for when reviewing:

The new libraries changed constant var names from using "-const-" to "_const_{a_unique_hex_string}_{type_info}" (See org.eclipse.rdf4j.query.algebra.helper.TupleExprs#getConstVarName(Value)). This broke a lot of our code but is now resolved through a new class we added named VarNameUtils. All hard-coded "-const-" strings were removed.
We added another new class, RdfFormatUtils, to handle the deprecation of RDFFormat#valueOf(String).
NumericLiteralImpl was deprecated. So, we replaced its use with AbstractValueFactory#createLiteral(BigInteger). I'm not sure I like this as it's a little unintuitive for creating an int with type XMLSchema.INTEGER instead of XMLSchema.INT. An alternative could be to use AbstractValueFactory#createLiteral(String, XMLSchema.INTEGER) which isn't much better but makes it clear that it must be XMLSchema.INTEGER.

ejwhite922

@jomach Go ahead and squash the 15 commits in here. After that, rebase off master. master's latest 2 commits need to be updated for RDF4J (hopefully just the last commit actually needs it). There might be a good amount of merge conflicts that need to be addressed.

Resolve conflicts # Conflicts: # common/rya.api/pom.xml # common/rya.api/src/main/java/org/apache/rya/api/resolver/RyaContext.java # extras/periodic.notification/api/src/main/java/org/apache/rya/periodic/notification/serialization/BindingSetSerDe.java # extras/periodic.notification/service/src/main/java/org/apache/rya/periodic/notification/application/PeriodicNotificationApplication.java # extras/periodic.notification/service/src/main/java/org/apache/rya/periodic/notification/application/PeriodicNotificationApplicationFactory.java # extras/periodic.notification/service/src/main/java/org/apache/rya/periodic/notification/exporter/KafkaExporterExecutor.java # extras/periodic.notification/service/src/main/java/org/apache/rya/periodic/notification/exporter/KafkaPeriodicBindingSetExporter.java # extras/periodic.notification/service/src/main/java/org/apache/rya/periodic/notification/processor/TimestampedNotificationProcessor.java # extras/rya.indexing.pcj/src/main/java/org/apache/rya/indexing/pcj/storage/accumulo/AccumuloPeriodicQueryResultStorage.java # extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/FilterResultUpdater.java # extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/export/kafka/KryoVisibilityBindingSetSerializer.java # extras/rya.pcj.fluo/pcj.fluo.integration/src/test/java/org/apache/rya/indexing/pcj/fluo/integration/KafkaExportIT.java

asfgit · 2017-11-09T20:29:25Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/550/

asfgit · 2017-11-09T20:53:58Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/551/

Build result: FAILURE

[...truncated 521.84 KB...][ERROR] location: class org.apache.rya.api.client.accumulo.AccumuloLoadStatements[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloLoadStatements.java:[103,32] cannot find symbol[ERROR] symbol: class RepositoryException[ERROR] location: class org.apache.rya.api.client.accumulo.AccumuloLoadStatements[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloLoadStatements.java:[110,32] cannot find symbol[ERROR] symbol: class RepositoryException[ERROR] location: class org.apache.rya.api.client.accumulo.AccumuloLoadStatements[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloLoadStatements.java:[117,32] cannot find symbol[ERROR] symbol: class SailException[ERROR] location: class org.apache.rya.api.client.accumulo.AccumuloLoadStatements[ERROR] -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :rya.indexingchannel stoppedSetting status of 46499cb to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/551/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing

asfgit · 2017-11-09T21:13:05Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/552/

Build result: FAILURE

[...truncated 1.60 MB...][INFO] ------------------------------------------------------------------------[INFO] Total time: 12:40 min[INFO] Finished at: 2017-11-09T21:12:49+00:00[INFO] Final Memory: 168M/2967M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on project rya.periodic.notification.twill: Compilation failure: Compilation failure:[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/periodic.notification/twill/src/main/java/org/apache/rya/periodic/notification/twill/PeriodicNotificationTwillRunnable.java:[70,86] incompatible types: org.apache.rya.periodic.notification.application.PeriodicNotificationApplicationConfiguration cannot be converted to java.util.Properties[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/periodic.notification/twill/src/main/java/org/apache/rya/periodic/notification/twill/PeriodicNotificationTwillRunnable.java:[94,16] cannot find symbol[ERROR] symbol: method blockUntilFinished()[ERROR] location: variable app of type org.apache.rya.periodic.notification.application.PeriodicNotificationApplication[ERROR] -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :rya.periodic.notification.twillchannel stoppedSetting status of 9d69ecc to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/552/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing

…its. Fixed more imports (#5)

asfgit · 2017-11-14T07:53:41Z

SUCCESS

asfgit · 2017-11-14T07:53:42Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/553/

jomach · 2017-11-14T10:31:47Z

@ejwhite922 looks good now

ejwhite922

This PR is on hold for a later release. A squashed down version of this PR can be found here (https://github.com/ejwhite922/incubator-rya/tree/RYA-405_MigrateSesameToRDF4J_TestSquash)

timea-solid · 2018-02-23T15:05:23Z

Hi there, this is interesting work and in my company we are looking forward to test out Apache Rya. However we use rdf4j already. Any idea when a new release in sight? I saw it was not added in the last RC.

asfgit · 2018-02-23T15:53:25Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/697/

ejwhite922 · 2018-04-09T15:23:18Z

@theRealImy Sorry for the late reply; I just started looking at this PR again. This PR will be a part of this release. I will start getting this updated with the latest commits since it was last worked on so it can be pulled in.

asfgit · 2018-04-09T16:16:59Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/726/

jomach · 2018-04-17T06:47:53Z

@ejwhite922 need any help ?

ejwhite922 · 2018-04-17T14:10:40Z

@jomach Thanks, but just waiting to hear if the dev list wants this in 3.2.13 or 4.0. Either way the updated PR is ready and should be up as soon as that issue is resolved. Hopefully this PR can get pulled in this week or next after it's been reviewed.

kchilton2 · 2018-04-17T16:52:10Z

@ejwhite922 Are you able to squash down the history where it makes sense so that this won't be messy when it goes in?

ejwhite922 · 2018-04-17T16:53:46Z

@kchilton2 Yea, it'll be one commit.

ejwhite922 · 2018-04-18T19:32:20Z

This can be closed. New PR under my branch is opened for it here (PR-291)

kchilton2 · 2018-04-24T18:31:57Z

This can be closed. Eric finished this work and it has been pulled into master.

ejwhite922 · 2018-04-24T18:51:03Z

@jomach could you close this PR when you have a chance? It's a duplicate of PR-291 which has been pulled in and closed. Thanks.

jomach added 3 commits October 18, 2017 11:32

Initial migration to rdf4j

dcc16b7

Initial migration to rdf4j

6b8db6c

RYA-405

6c636d4

Initial migration to rdf4j

jomach added 2 commits October 19, 2017 09:20

RYA-405

359194a

Fixing compile errors

RYA-405

19126bb

More Compile fixing errors

RYA-405

0b13fdb

More Compile fixing errors

ejwhite922 reviewed Oct 19, 2017

View reviewed changes

isper3at reviewed Oct 19, 2017

View reviewed changes

RYA-405

38c1c0c

Try to fix DocumentIndexIntersectingIteratorTest

RYA-405

83cb21b

Create AccumuloMiniCluster to Run Tests

ejwhite922 reviewed Oct 23, 2017

View reviewed changes

ejwhite922 reviewed Oct 24, 2017

View reviewed changes

RYA-405

c3ef8c9

-Fixing stuff

Rya 405 Integration test fixes and more import fixes (#4)

ac58919

* RYA-405 Fixing more imports * RYA-405 Fixes for integration tests * RYA-405 Fixed license mixed in imports

ejwhite922 reviewed Nov 9, 2017

View reviewed changes

Add missing import

46499cb

Add missing import

9d69ecc

RYA-405 Resolved merge conflicts that were removed from previous comm…

b19af3a

…its. Fixed more imports (#5)

ejwhite922 reviewed Nov 20, 2017

View reviewed changes

ejwhite922 mentioned this pull request Jan 10, 2018

RYA-417 Forward-chaining batch rules engine #255

Closed

2 tasks

ejwhite922 mentioned this pull request Apr 18, 2018

RYA-405 Migration of OpenRDF Sesame libraries to RDF4J #291

Closed

2 tasks

jomach closed this Apr 24, 2018


		import com.google.common.base.Optional;
		import static java.util.Objects.requireNonNull;

[RYA-405] Migrate from Sesame to rdf4j libs #245

[RYA-405] Migrate from Sesame to rdf4j libs #245

Conversation

jomach commented Oct 18, 2017

Description

Tests

Links

Checklist

People To Reivew

asfgit commented Oct 18, 2017

amihalik commented Oct 18, 2017

asfgit commented Oct 18, 2017

isper3at commented Oct 19, 2017

jomach commented Oct 19, 2017

isper3at commented Oct 19, 2017

jomach commented Oct 19, 2017

isper3at commented Oct 19, 2017

jomach commented Oct 19, 2017

ejwhite922 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jomach commented Oct 19, 2017

isper3at commented Oct 19, 2017

isper3at commented Oct 19, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asfgit commented Oct 19, 2017

Build result: FAILURE

jomach commented Oct 20, 2017 • edited

asfgit commented Oct 20, 2017

Build result: ABORTED

ejwhite922 left a comment

Choose a reason for hiding this comment

jomach commented Oct 24, 2017

ejwhite922 left a comment

Choose a reason for hiding this comment

jomach commented Oct 24, 2017

jomach commented Nov 5, 2017

asfgit commented Nov 9, 2017

ejwhite922 left a comment

Choose a reason for hiding this comment

ejwhite922 left a comment

Choose a reason for hiding this comment

asfgit commented Nov 9, 2017

asfgit commented Nov 9, 2017

Build result: FAILURE

asfgit commented Nov 9, 2017

Build result: FAILURE

asfgit commented Nov 14, 2017

asfgit commented Nov 14, 2017

jomach commented Nov 14, 2017

ejwhite922 left a comment

Choose a reason for hiding this comment

timea-solid commented Feb 23, 2018

asfgit commented Feb 23, 2018

ejwhite922 commented Apr 9, 2018 • edited

asfgit commented Apr 9, 2018

jomach commented Apr 17, 2018

ejwhite922 commented Apr 17, 2018

kchilton2 commented Apr 17, 2018

ejwhite922 commented Apr 17, 2018

ejwhite922 commented Apr 18, 2018

kchilton2 commented Apr 24, 2018

ejwhite922 commented Apr 24, 2018

isper3at commented Oct 19, 2017 •

edited

jomach commented Oct 20, 2017 •

edited

ejwhite922 commented Apr 9, 2018 •

edited