RYA-73 added timestamp to mongoDB DAO #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the mongo storage strategy to now include timestamp in the [de]serialization of RyaStatements. The timestamp is added at insertion timein the DAO Added test for [de]serialize Added test for timestamp in the DAO
|
Hi @isper3at , |
|
updated, should be fixed. |
|
looks good. will merge tomorrow. good job adding tests. |
|
oh kind of not related to this pr, but should we consider adding context to the mongo composite indices? |
|
merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the mongo storage strategy to now
include timestamp in the [de]serialization
of RyaStatements.
The timestamp is added at insertion timein the DAO
Added test for [de]serialize
Added test for timestamp in the DAO
Added failsafe to mongo rya for integration test framework
Jira