RYA-169 MongoRya DAO/Examples fixed #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed updateMongoConfig() from RyaSailFactory, used MongoConnectorFactory. Credentials are now optional for MongoDB. Removed null checks for credentials.
DLotts
force-pushed
the
RYA-169_MongoExamples
branch
from
00d2cb8
to
d5087aa
Compare
|
🚢 🇮🇹 Looks good |
|
looks good. About to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed a redundant method and call in RyaSailFactory to get/create a Mongo client/connection. Mongo should only have one client per JVM. So the MongoConnectorFactory is used.
Credentials are now optional for MongoDB.
Tests
MongoRyaDirectExample.java runs without error.
Links
Jira RYA-169
Checklist
People To Reivew
isper3at