RYA-165 Simplify PCJ result visibility expressions before exporting t… #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param visibility - The expression to simplify. (not null) | ||
| * @return A simplified form of {@code visibility}. | ||
| */ | ||
| public String simplify(final String visibility) { |
There was a problem hiding this comment.
👍 I feel like this is how it should've been implemented in flatten()
|
everything looks good to me. I like the changes. We using Objects.requireNonNull() inplace of Preconditions moving forward? I still see both used in various places |
| @@ -54,6 +58,16 @@ | |||
| private static final VisibilityBindingSetStringConverter CONVERTER = new VisibilityBindingSetStringConverter(); | |||
|
|
|||
| /** | |||
| * Simplifies Visibility expressions prior to exporting PCJ results. | |||
| */ | |||
| private static final VisibilitySimplifier SIMPLIFIER = new VisibilitySimplifier(); | |||
There was a problem hiding this comment.
Is there a reason the simplify method isn't static (why are we creating this class)?
There was a problem hiding this comment.
Static code is harder to test and extend, so I just shy away from it.
amihalik
approved these changes
Sep 14, 2016
kchilton2
commented
Sep 14, 2016
| @@ -32,28 +30,36 @@ | |||
| public class VisibilityBindingSetStringConverter extends BindingSetStringConverter { | |||
| public static final char VISIBILITY_DELIM = 1; | |||
|
|
|||
| private static final int BINDING_SET_STRING_INDEX = 0; | |||
| private static final int VISIBILITY_EQUATION_INDEX = 1; | |||
There was a problem hiding this comment.
This is an expression, not an equation.
…hem to the Rya PCJ index table.
|
looks good. about to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amihalik
@isper3at