SDAP-75 #22
SDAP-75 #22
Conversation
"InterruptedException" should not be ignored
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
@quintinali there are several areas for improvement here please address the comments, thanks.
| FileWriter fw; | ||
| try { | ||
| fw = new FileWriter(file.getAbsoluteFile()); | ||
| try(FileWriter fw = new FileWriter(file.getAbsoluteFile())){ | ||
| bw = new BufferedWriter(fw); |
There was a problem hiding this comment.
Should this BufferedWriter not also be pulled into the try-with-resources?
There was a problem hiding this comment.
The ontology module is written by you and I'm not familiar with functions in the class. I found bw is defined as a class variable and can't be pulled it into the try-with-resource since bw is used in other functions.
| } catch (IOException e1) { | ||
| e1.printStackTrace(); | ||
| File[] files = new File(this.props.getProperty(MudrodConstants.ONTOLOGY_INPUT_PATH)).listFiles(); | ||
| for (File file_in : files) { |
There was a problem hiding this comment.
file_in does not comply with Java code conventions.
It should be changed to fileIn
| String ext = FilenameUtils.getExtension(file_in.getAbsolutePath()); | ||
| if ("owl".equals(ext)) { | ||
| try { | ||
| loadxml(file_in.getAbsolutePath()); |
There was a problem hiding this comment.
loadxml should be changed to loadXml
| } | ||
| } catch (IOException e) { | ||
| // TODO Auto-generated catch block |
There was a problem hiding this comment.
Never leave comment stubs present in production level code. Either LOG or rethrow this exception.
| @@ -91,6 +91,7 @@ public Object execute() { | |||
| e.printStackTrace(); | |||
| } catch (InterruptedException e) { | |||
| e.printStackTrace(); | |||
There was a problem hiding this comment.
We should not be printing these stack traces, we should be logging them or re-throwing the exceptions.
Fix bugs in AggregateTriple.java found by sonar coverage