Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rsync to transfer clickhouse data file #2074

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Conversation

Emor-nj
Copy link
Contributor

@Emor-nj Emor-nj commented Jun 28, 2022

Purpose of this pull request

#2073
Support Rsync to transfer clickhouse data file.

@Emor-nj
Copy link
Contributor Author

Emor-nj commented Jun 28, 2022

@Hisoka-X Please have a look, and give me some advice.Thank you!

Comment on lines 59 to 63
<dependency>
<groupId>com.github.fracpete</groupId>
<artifactId>rsync4j-all</artifactId>
<version>3.2.3-10</version>
</dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://mvnrepository.com/artifact/com.github.fracpete/rsync4j-all

The Apache License and GPL are not compatible and we cannot use this dependency

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I will try to use the buildin package scala.sys.process to build rsync shell command to realize this feature. And recommit it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I will try to use the buildin package scala.sys.process to build rsync shell command to realize this feature. And recommit it.

After you change, ping me. thx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hisoka-X i have changed and passed the simple test in spark-local mode , please check it.

Hisoka-X
Hisoka-X previously approved these changes Jun 29, 2022
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done!

@Hisoka-X
Copy link
Member

Can you submit this feature to our new seatunnel api connector? If so, it's very wonderful.

@Emor-nj
Copy link
Contributor Author

Emor-nj commented Jun 29, 2022

Can you submit this feature to our new seatunnel api connector? If so, it's very wonderful.

Sure, I'm happy to do it.

@Hisoka-X Hisoka-X merged commit 858c5a8 into apache:dev Jun 29, 2022
@Emor-nj Emor-nj deleted the rsync-ck branch June 29, 2022 06:43
@CalvinKirs CalvinKirs added this to the 2.1.3 milestone Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants