Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][flink-api]extraction unified method #2862

Merged
merged 3 commits into from Sep 28, 2022
Merged

[Improve][flink-api]extraction unified method #2862

merged 3 commits into from Sep 28, 2022

Conversation

liugddx
Copy link
Member

@liugddx liugddx commented Sep 23, 2022 •
edited

Purpose of this pull request

extraction unified method

Check list

EricJoy2048
EricJoy2048 previously approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Hisoka-X
Hisoka-X reviewed Sep 26, 2022
View reviewed changes
...nnel-apis/seatunnel-api-flink/src/main/java/org/apache/seatunnel/flink/FlinkEnvironment.java Outdated
@@ -322,4 +325,18 @@ private void setCheckpoint() {
}
}

public void registerResultTable(Config config, String tableName, DataStream<Row> dataStream) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tableName always be RESULT_TABLE_NAME, so you can remove it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Hisoka-X
Hisoka-X approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EricJoy2048
EricJoy2048 approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liugddx
Copy link
Member Author

liugddx commented Sep 27, 2022

CI is error ,and i think it's because the JdbcPostgresIT and JdbcMysqlIT are unstable.and i tested it locally and the error also happen. so i fix it in #2907 .

@liugddx
Copy link
Member Author

liugddx commented Sep 27, 2022

CI is error ,and i think it's because the JdbcPostgresIT and JdbcMysqlIT are unstable.and i tested it locally and the error also happen. so i fix it in #2907 .

@EricJoy2048 please rerun CI,thanks. CC @ic4y

@EricJoy2048
Copy link
Member

#2907

Ok, I will rerun the failed job after the #2907 been merged.

@liugddx
Copy link
Member Author

liugddx commented Sep 28, 2022

please rerun CI. @EricJoy2048

hailin0
hailin0 reviewed Sep 28, 2022
View reviewed changes
Copy link
Contributor

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashulin
ashulin approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@ashulin ashulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashulin ashulin merged commit 1148412 into apache:dev Sep 28, 2022
@liugddx liugddx deleted the improve-extractmethod branch September 28, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 left review comments

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@ashulin ashulin ashulin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liugddx @EricJoy2048 @hailin0 @Hisoka-X @ashulin