Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Imporve][Seatunnel-code][Seatunnel-flink-starter] customize operator parallel for flink and spark #2941

Merged
merged 13 commits into from
Oct 18, 2022

Conversation

liugddx
Copy link
Member

@liugddx liugddx commented Sep 28, 2022

close #2925

Purpose of this pull request

customize operator parallel

Check list

@liugddx liugddx marked this pull request as draft September 28, 2022 14:50
@hailin0
Copy link
Member

hailin0 commented Sep 30, 2022

great

@liugddx liugddx marked this pull request as ready for review October 5, 2022 14:40
@liugddx liugddx changed the title [Imporve][api] customize operator parallel [Imporve][Seatunnel-code][Seatunnel-flink-starter] customize operator parallel for flink Oct 5, 2022
@@ -53,8 +53,10 @@ transform {
}

sink {
Console {}
Console {
execution.parallelism = 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we use the unified parameters parallelism

name = "string"
age = "int"
}
FakeSource {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add parallelism config in FakeSource. Also please update doc

EricJoy2048
EricJoy2048 previously approved these changes Oct 11, 2022
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@liugddx liugddx requested a review from Hisoka-X October 12, 2022 07:35
@liugddx
Copy link
Member Author

liugddx commented Oct 14, 2022

@Hisoka-X PTALthanks

@liugddx
Copy link
Member Author

liugddx commented Oct 15, 2022

@ashulin help to review thanks.

@Hisoka-X
Copy link
Member

Can you add spark for support this parameter too? Because you put parallelism into common-options, but spark not support.

@liugddx
Copy link
Member Author

liugddx commented Oct 17, 2022

Can you add spark for support this parameter too? Because you put parallelism into common-options, but spark not support.

Done. @EricJoy2048 @Hisoka-X

@Hisoka-X Hisoka-X changed the title [Imporve][Seatunnel-code][Seatunnel-flink-starter] customize operator parallel for flink [Imporve][Seatunnel-code][Seatunnel-flink-starter] customize operator parallel for flink and spark Oct 17, 2022
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs CalvinKirs merged commit d6f8268 into apache:dev Oct 18, 2022
@liugddx liugddx deleted the customizeparaller branch November 5, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][DISCUSS] operator support customize some feature configurations,like parallel
5 participants