Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Clickhouse-V2] Clickhouse Support Geo type #3141

Merged
merged 15 commits into from Nov 2, 2022

Conversation

FWLamb
Copy link
Contributor

@FWLamb FWLamb commented Oct 19, 2022

Purpose of this pull request

Clickhouse Sink Support write Geo type #3101
Clickhouse Source also Support Geo type.

Check list

@FWLamb
Copy link
Contributor Author

FWLamb commented Oct 19, 2022

Maybe we need to change the version of clickhouse-jdbc in the future. ClickHouse/clickhouse-java#1112

@Hisoka-X
Copy link
Member

Hisoka-X commented Oct 21, 2022

Please use e2e to test these type.

@FWLamb
Copy link
Contributor Author

FWLamb commented Oct 21, 2022

Point and Ring data types passed the e2e test. Polygon and MultiPolygon cannot be used temporarily because of a bug in clickhouse jdbc. Please track ClickHouse/clickhouse-java#1112

@Hisoka-X
Copy link
Member

@FWLamb FWLamb mentioned this pull request Oct 26, 2022
3 tasks
@FWLamb
Copy link
Contributor Author

FWLamb commented Oct 31, 2022

@Hisoka-X PTAL

Hisoka-X
Hisoka-X previously approved these changes Oct 31, 2022
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the improve to Clickhouse Connector doc and add the changed log reference https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/connector-v2/source/Redis.md#next-version

@FWLamb
Copy link
Contributor Author

FWLamb commented Nov 1, 2022

Please add the improve to Clickhouse Connector doc and add the changed log reference https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/connector-v2/source/Redis.md#next-version

all right

@FWLamb
Copy link
Contributor Author

FWLamb commented Nov 1, 2022

#3067
#3047
@EricJoy2048 Do the above two PRs also need to be added?

@Hisoka-X
Copy link
Member

Hisoka-X commented Nov 1, 2022

#3067 #3047 @EricJoy2048 Do the above two PRs also need to be added?

Yes, add it together.

@FWLamb
Copy link
Contributor Author

FWLamb commented Nov 1, 2022

#3067 #3047 @EricJoy2048 Do the above two PRs also need to be added?

Yes, add it together.

all right

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs CalvinKirs merged commit 01cdc4e into apache:dev Nov 2, 2022
@FWLamb FWLamb deleted the clickhouse_sink_support_write_geo_type branch November 22, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants