Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connector] [Dependency] Add Miss Dependency Cassandra And Change Kudu Plugin Name #3432

Merged
merged 6 commits into from Nov 21, 2022
Merged

[Connector] [Dependency] Add Miss Dependency Cassandra And Change Kudu Plugin Name #3432

merged 6 commits into from Nov 21, 2022

Conversation

Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented Nov 14, 2022 •
edited

Purpose of this pull request

  1. Add Miss Dependency Cassandra
  2. Fix PluginIdentifier equals method problem

Check list

hailin0
hailin0 previously approved these changes Nov 15, 2022
View reviewed changes
hailin0
hailin0 previously approved these changes Nov 15, 2022
View reviewed changes
CalvinKirs
CalvinKirs previously approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to change to seatunnel.source.Kudu = connector-kudu
It's better to be consistent.

TyrantLucifer
TyrantLucifer previously approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@TyrantLucifer
Copy link
Member

It is recommended to change to seatunnel.source.Kudu = connector-kudu It's better to be consistent.

Aggre with you.

@Hisoka-X
Copy link
Member Author

It is recommended to change to seatunnel.source.Kudu = connector-kudu It's better to be consistent.

Done

ashulin
ashulin approved these changes Nov 19, 2022
View reviewed changes
Copy link
Member

@ashulin ashulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hailin0
hailin0 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the title

@Hisoka-X Hisoka-X changed the title [Connector] [Dependency] Add Miss Dependency Cassandra [Connector] [Dependency] Add Miss Dependency Cassandra And Change Kudu Plugin Name Nov 21, 2022
@Hisoka-X
Copy link
Member Author

please update the title

Done

@Hisoka-X Hisoka-X merged commit 6ac6a0a into apache:dev Nov 21, 2022
@Hisoka-X Hisoka-X deleted the add-miss-dependency branch November 21, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 approved these changes

@ashulin ashulin ashulin approved these changes

@CalvinKirs CalvinKirs CalvinKirs left review comments

@TyrantLucifer TyrantLucifer TyrantLucifer left review comments

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Hisoka-X @TyrantLucifer @hailin0 @CalvinKirs @ashulin