New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][Connector-V2][Kafka] Support extract topic from SeaTunnelRow field #3742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add e2e testcase
Writing e2e test for this feature is not easy because the kafka sink connector send records without callback function, so I took a screenshot to prove that the feature is available. |
|
Thanks for your advice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...afka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkWriter.java
Outdated
Show resolved
Hide resolved
I added e2e test for this feature and refactor the kafkaIT code.PTAL @hailin0 @EricJoy2048 @Hisoka-X |
...afka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkWriter.java
Outdated
Show resolved
Hide resolved
...afka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkWriter.java
Outdated
Show resolved
Hide resolved
...afka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkWriter.java
Outdated
Show resolved
Hide resolved
...afka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkWriter.java
Outdated
Show resolved
Hide resolved
...afka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkWriter.java
Outdated
Show resolved
Hide resolved
...afka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkWriter.java
Outdated
Show resolved
Hide resolved
Let's waiting CICD. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of this pull request
Support extract topic from SeaTunnelRow field
For test :
source config :
sink config :
send records to topic:
Check list
New License Guide