Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][KafkaSource]Failed to parse offset format #3810

Merged
merged 3 commits into from Dec 28, 2022

Conversation

lightzhao
Copy link
Contributor

When the kafka source is started in offset mode, when the topicName has a "-", the exception will be resolved, causing the assignment to fail.
example:
start_mode = "specific_offsets"
start_mode.offsets = {
my-topic-test-0 = 1
}
topicName is my, partition is topic-test-0.

Purpose of this pull request

Check list

…as a "-", the exception will be resolved, causing the assignment to fail
@TaoZex
Copy link
Contributor

TaoZex commented Dec 27, 2022

PTAL @Carl-Zhou-CN

@lightzhao
Copy link
Contributor Author

@TaoZex @Carl-Zhou-CN please review, thanks.

Carl-Zhou-CN
Carl-Zhou-CN previously approved these changes Dec 28, 2022
Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

TyrantLucifer
TyrantLucifer previously approved these changes Dec 28, 2022
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TaoZex
TaoZex previously approved these changes Dec 28, 2022
Copy link
Contributor

@TaoZex TaoZex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Hisoka-X
Hisoka-X previously approved these changes Dec 28, 2022
@Hisoka-X
Copy link
Member

Hi, Please update doc to add this change to change-log

@lightzhao
Copy link
Contributor Author

Hi, Please update doc to add this change to change-log

done, thanks. please merge.

Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Hisoka-X Hisoka-X merged commit 8e1196a into apache:dev Dec 28, 2022
@lightzhao lightzhao deleted the kafkasource-start-offset branch December 28, 2022 06:48
lhyundeadsoul pushed a commit to lhyundeadsoul/incubator-seatunnel that referenced this pull request Jan 3, 2023
* When the kafka source is started in offset mode, when the topicName has a "-", the exception will be resolved, causing the assignment to fail

* fix code style.

* update change-log

Co-authored-by: zhaoliang01 <zhaoliang01@58.com>
lhyundeadsoul pushed a commit to lhyundeadsoul/incubator-seatunnel that referenced this pull request Jan 3, 2023
* When the kafka source is started in offset mode, when the topicName has a "-", the exception will be resolved, causing the assignment to fail

* fix code style.

* update change-log

Co-authored-by: zhaoliang01 <zhaoliang01@58.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants