[SEDONA-18] error reading shapefile #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
您好，您的邮件我已收到，我会尽快给您回复。谢谢!
|
madzik555
changed the title
jiayuasu
changed the title
jiayuasu
requested changes
Dec 9, 2021
There was a problem hiding this comment.
Thank you for your contribution! Can you use the existing shapefile (with an additional file inside that has a different file extension) in the resources and use the existing test cases to validate the new patch, instead of introducing a new shapefile?
There are two reasons behind this:
- A new shapefile introduces to additional copyright issue
- This new shapefile increases the source code size.
|
No problem. I can do this |
jiayuasu
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this PR related to a proposed Issue?
https://issues.apache.org/jira/browse/SEDONA-18
What changes were proposed in this PR?
In function getSplits() (core/src/main/java/org/apache/sedona/core/formatMapper/shapefileParser/shapes/ShapeInputFormat.java), the condition that splits file names by name only has been changed. Before the change, files with a different name and a different extension were treated as a separate data package, in which specific files could not be found.
How was this patch tested?
New java unit test.
Did this PR include necessary documentation updates?
No