Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAV-508] & [SCB-11] Metrics Auto Publish #453

Closed
wants to merge 3 commits into from

Conversation

zhengyangyong
Copy link

@zhengyangyong zhengyangyong commented Dec 21, 2017

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [JAV-XXX] Fixes bug in ApproximateQuantiles, where you replace JAV-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

JAV-508 & SCB-11 Metrics Auto Publish

If user include metrics in dependency,the metrics service would auto publish with Java Chassis Producer,also use same transport and endpoint config.
For example if user config rest address 0.0.0.0:8080 in microservice.yaml,then the metrics service will available at http://:8080/metrics

zhengyangyong added 2 commits December 21, 2017 09:24
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
}

@Override
public String metrics(int pollerIndex) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It‘s not a good way to just return the string here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a3f28f7 on zhengyangyong:JAV-508&SCB-11 into ** on apache:master**.

@zhengyangyong
Copy link
Author

this will be improve after this PR : #451 had fully discuss via mail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants