Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-260 Clarify copyright of HystrixCommandPropertiesExt #554

Merged
merged 1 commit into from Feb 11, 2018

Conversation

yangbor
Copy link
Member

@yangbor yangbor commented Feb 11, 2018

The majority of the HystrixCommandPropertiesExt class is forked
from the base class. Thus we need to keep the original copyright.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

The majority of the HystrixCommandPropertiesExt class is forked
from the base class. Thus we need to keep the original copyright.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 87.261% when pulling 7e0bda2 on yangbor:master into cfc66b9 on apache:master.

@WillemJiang WillemJiang merged commit 9720cfc into apache:master Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants