Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-6] add metrics samples readme #580

Merged
merged 1 commit into from Mar 9, 2018

Conversation

zhengyangyong
Copy link

@zhengyangyong zhengyangyong commented Mar 9, 2018

Signed-off-by: zhengyangyong yangyong.zheng@huawei.com

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Add README.md for metrics health check sample and write metrics to file sample

Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 87.189% when pulling c44586f on zhengyangyong:SCB-6-SampleDoc into e1137b4 on apache:master.

Copy link
Member

@asifdxtreme asifdxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WillemJiang WillemJiang merged commit 68c4d0e into apache:master Mar 9, 2018
@zhengyangyong zhengyangyong deleted the SCB-6-SampleDoc branch March 27, 2018 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants