Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule #657

Merged
merged 2 commits into from Apr 23, 2018

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@wujimin
Copy link
Contributor

wujimin commented Apr 18, 2018

paste compile warning check image please.

@coveralls
Copy link

coveralls commented Apr 18, 2018

Coverage Status

Coverage decreased (-0.07%) to 87.371% when pulling 33769e9 on liubao68:config into 41049be on apache:master.

@liubao68
Copy link
Contributor Author

I am using eclipse and all compile warnings fixed except #652

@liubao68 liubao68 merged commit a16b049 into apache:master Apr 23, 2018
@liubao68 liubao68 deleted the config branch April 25, 2018 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants