Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-453] Read config from application yaml properties #660

Merged

Conversation

yhs0092
Copy link
Member

@yhs0092 yhs0092 commented Apr 19, 2018

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Support reading ServiceComb configurations from application.yaml/application.properties
See SCB-453
compile_warning

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 87.482% when pulling 5977c32 on yhs0092:read_config_from_application_yaml_properties into 41049be on apache:master.

@wujimin wujimin mentioned this pull request Apr 19, 2018
6 tasks
@liubao68 liubao68 merged commit 737870a into apache:master Apr 20, 2018
@yhs0092 yhs0092 deleted the read_config_from_application_yaml_properties branch July 23, 2018 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants