Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCB-534] remove generate generic class from swagger related comments… #701

Merged
merged 1 commit into from May 16, 2018
Merged

[SCB-534] remove generate generic class from swagger related comments… #701

merged 1 commit into from May 16, 2018

Conversation

wujimin
Copy link
Contributor

@wujimin wujimin commented May 14, 2018

unnecessary to generate generic class from swagger:

in normal process: already have related model, no need to create dynamically
in edge: create or not, there is no any difference

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 87.349% when pulling f6aa388 on wujimin:generate-generic into 2f8de34 on apache:master.

@liubao68 liubao68 merged commit 61cda00 into apache:master May 16, 2018
@wujimin wujimin deleted the generate-generic branch July 11, 2018 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillemJiang WillemJiang WillemJiang approved these changes

@liubao68 liubao68 liubao68 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wujimin @coveralls @WillemJiang @liubao68