[SCB-637] Enhance HttpServletRequestEx impl #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rlencoded even not post request (servlet 3.1 defined only parsed for post request)
…ClientRequestToHttpServletRequest/VertxServerRequestToHttpServletRequest/InvocationToHttpServletRequest
wujimin
changed the title
liubao68
approved these changes
Jun 4, 2018
WillemJiang
reviewed
Jun 4, 2018
| return super.getParameterMap(); | ||
| } | ||
|
|
||
| Map<String, List<String>> listMap = parseUrlEncodedBody(); |
There was a problem hiding this comment.
If the content type is not url encoded, we will consume the input stream, and we cannot read the body content again.
I think the need to check the content type before parse the body.
There was a problem hiding this comment.
already checked between line 104~107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.