Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-350] if the file not exist, make a warn log to trace it. make th… #749

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

jeho0815
Copy link
Contributor

@jeho0815 jeho0815 commented Jun 5, 2018

…e error more clearly

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@jeho0815
Copy link
Contributor Author

jeho0815 commented Jun 5, 2018

Add a warn log to help the developer know the error more simple

[2018-06-05 09:41:48,247/CST][transport-vert.x-eventloop-thread-4][WARN]keyStore [server1.p12] file not exist, please check! org.apache.servicecomb.foundation.vertx.VertxTLSBuilder.buildTCPSSLOptions(VertxTLSBuilder.java:116)
[2018-06-05 09:41:48,282/CST][transport-vert.x-eventloop-thread-4][ERROR] org.apache.servicecomb.transport.rest.vertx.RestServerVerticle.start(RestServerVerticle.java:78)
io.vertx.core.VertxException: io.vertx.core.VertxException: Key/certificate is mandatory for SSL
	at io.vertx.core.net.impl.SSLHelper.createContext(SSLHelper.java:305)
	at io.vertx.core.net.impl.SSLHelper.getContext(SSLHelper.java:447)
	at io.vertx.core.net.impl.SSLHelper.validate(SSLHelper.java:467)
	at io.vertx.core.http.impl.HttpServerImpl.listen(HttpServerImpl.java:258)
	at org.apache.servicecomb.transport.rest.vertx.RestServerVerticle.startListen(RestServerVerticle.java:104)
	at org.apache.servicecomb.transport.rest.vertx.RestServerVerticle.start(RestServerVerticle.java:75)
	at io.vertx.core.impl.DeploymentManager.lambda$doDeploy$10(DeploymentManager.java:481)
	at io.vertx.core.impl.ContextImpl.lambda$wrapTask$2(ContextImpl.java:344)
	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)
	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:463)
	at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.lang.Thread.run(Thread.java:748)
Caused by: io.vertx.core.VertxException: Key/certificate is mandatory for SSL
	at io.vertx.core.net.impl.SSLHelper.createContext(SSLHelper.java:265)
	... 13 more

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 87.477% when pulling 2b61d52 on jeho0815:Branch_master_SCB350 into 517a9ff on apache:master.

@liubao68 liubao68 merged commit 32e452f into apache:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants