[SCB-484] Servlet rest support download #750
Conversation
wujimin
force-pushed
the
servlet-rest-support-download
branch
from
bbabccb
to
3a7e22b
Compare
| action.run(); | ||
| } | ||
| } catch (IOException e) { | ||
| currentBufferCount--; |
There was a problem hiding this comment.
Here is no sychronized. If we just need to make sure currentBufferCount is automatic, we don't need to use the synchroized to do this job.
There was a problem hiding this comment.
not just protect currentBufferCount, we must protect close/drain logic.
| /** | ||
| * for pump from a readStream | ||
| */ | ||
| public class OutputStreamToWriteStream implements WriteStream<Buffer>, AsyncCloseable<Void> { |
There was a problem hiding this comment.
Too much synchronized in this class, if we can make sure there is only one thread handle this write stream, that could make our life much easier.
There was a problem hiding this comment.
if readStream and writeStream both are vertx eventloop stream, then it's only one thread
but if one of readStream and writeStream is wrapped from a blocked stream(inputStream/outputStream), then it's multiple thread
so we must use synchronized logic just like vertx asyncFile do.
did not provide download integration test, but already test locally
because upload did not support for servlet yet,
but it's not good to delete upload test case.