[SCB-679] Support Cross-Origin Resource Sharing (CORS) #771
Conversation
|
Wait for a sec, I need to add some fix in this pr. |
|
Done. Please review.
|
| @@ -31,3 +31,10 @@ servicecomb: | |||
| address: http://127.0.0.1:30100 | |||
| rest: | |||
| address: 127.0.0.1:8080 | |||
| cors: | |||
There was a problem hiding this comment.
Support Cross-Origin Resource Sharing (CORS)
| + "It's recommended to increment microservice version before deploying.", scSchemaMap.keySet()); | ||
| + "It's recommended to increment microservice version before deploying.", | ||
| scSchemaMap.keySet()); | ||
| LOGGER.warn("ATTENTION: The schemas in new version are less than the old version, " |
There was a problem hiding this comment.
I think this warning message is the same as above one. Anyway, it's fine to keep it.
There was a problem hiding this comment.
This is for the review opinion in another PR-757. I need to warn users to take care of compatibility issues.
I don't know how to describe it clearer with my poor English :P
| @@ -36,5 +36,6 @@ | |||
|
|
|||
| <bean id="cse.executor.groupThreadPool" class="org.apache.servicecomb.core.executor.FixedThreadExecutor"></bean> | |||
| <alias name="cse.executor.groupThreadPool" alias="cse.executor.default"/> | |||
| <alias name="cse.executor.groupThreadPool" alias="servicecomb.executor.groupThreadPool"/> | |||
| <bean id="cse.executor.reactive" class="org.apache.servicecomb.core.executor.ReactiveExecutor"></bean> | |||
There was a problem hiding this comment.
cse.executor.reactive also need a alias?
There was a problem hiding this comment.
an alias has been added for cse.executor.reactive
| @@ -32,12 +40,14 @@ | |||
| private static HelloWorld helloWorld; | |||
|
|
|||
| public static void main(String[] args) throws Exception { | |||
| System.setProperty("sun.net.http.allowRestrictedHeaders", "true"); | |||
There was a problem hiding this comment.
a little strange
crossapp demo is to verify cross ServiceComb application
but no problem, we will merge most demo and integration test to one or two project in the future.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.See details in SCB-679