Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-767]When using Response to return multi-code message, handlers /filters given ClassCaseException #827

Merged
merged 2 commits into from
Jul 25, 2018

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

coveralls commented Jul 20, 2018

Coverage Status

Coverage decreased (-0.3%) to 86.668% when pulling a2722a7 on liubao68:response-fail into a1d0804 on apache:master.

Copy link
Contributor

@wujimin wujimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems it's simpler that change user model to InvocationException in SwaggerProducerOperation
only need to change two position, and other mechanism can use the same rule to process response

@liubao68
Copy link
Contributor Author

After modification to service implementation, this scenario is not a bug. But user may have the same problem when they use it this way, just commit the test codes as an example.

@wujimin wujimin merged commit 5c1c3e2 into apache:master Jul 25, 2018
@liubao68 liubao68 deleted the response-fail branch July 26, 2018 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants