[SCB-788] public key black/white add feature: choose server by version #846
Conversation
| if ("serviceName".equals(item.propertyName)) { | ||
| if (isPatternMatch(microservice.getServiceName(), item.rule)) { | ||
| matched = true; | ||
| break; | ||
| } | ||
| } | ||
| if ("version".equals(item.propertyName)) { | ||
| if (isVersionMatch(microservice.getVersion(), item.rule)) { |
There was a problem hiding this comment.
Why not use isPatternMatch here?
There was a problem hiding this comment.
yes,i'll modify it
| if ("serviceName".equals(item.propertyName)) { | ||
| if (isPatternMatch(microservice.getServiceName(), item.rule)) { | ||
| matched = true; | ||
| break; | ||
| } | ||
| } | ||
| if ("version".equals(item.propertyName)) { |
There was a problem hiding this comment.
Maybe you can write this code using reflection to find all Microservice String getters and match in a general way to avoid many if statements. So that we can support all properties, e.g. serviceName, appId, environment, alias and so on. And when getters not exists, we may search properties of Microservice(properties is a map) for the key.
There was a problem hiding this comment.
ok, i will deal with this
weichao666
force-pushed
the
blacksupportversion
branch
from
f9ba502
to
bc322ad
Compare
| Field field; | ||
| String fieldValue = null; | ||
| try { | ||
| field = service.getDeclaredField(fieldName); |
There was a problem hiding this comment.
Invoke the getter method directly, do not need set accessible to true.
| break; | ||
| // we support to configure properties, e.g. serviceName, appId, environment, alias, version and so on, also support key in properties. | ||
| Class<? extends Microservice> service = microservice.getClass(); | ||
| for (Method method : service.getDeclaredMethods()) { |
There was a problem hiding this comment.
Maybe iterate all fields and find the Read Method is more elegant implementation. See https://stackoverflow.com/questions/28697484/how-to-invoke-a-getter-method-by-its-name
| String methodName = method.getName(); | ||
| if (!methodName.startsWith("get")) | ||
| continue; | ||
| if (!method.getGenericReturnType().getTypeName().equals(TYPE_STRING_NAME)) |
There was a problem hiding this comment.
maybe write two short methods, e.g. matchMicroserviceField & matchMicroserviceProperties to avoid this method too long.
| @@ -54,6 +57,8 @@ | |||
|
|
|||
| private static final String KEY_RULE_POSTFIX = ".rule"; | |||
|
|
|||
| private static final String TYPE_STRING_NAME = "java.lang.String"; | |||
There was a problem hiding this comment.
String.class.getName maybe is better
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.