Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-920]Remove duplicate dependencies #910

Closed
wants to merge 1 commit into from
Closed

[SCB-920]Remove duplicate dependencies #910

wants to merge 1 commit into from

Conversation

laijianbin
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 86.308% when pulling 5eca0ca on laijianbin:patch-3 into 4dbc83a on apache:master.

@wujimin
Copy link
Contributor

wujimin commented Sep 17, 2018

sorry, i did not find any duplicate dependencies of your modification
can you show me the problem?

@laijianbin
Copy link
Contributor Author

image
spring-webmvc contains those dependencies,so I think there is no need import any more

@liubao68
Copy link
Contributor

liubao68 commented Sep 18, 2018

This PR is not correct. How about a module do not dependent on spring-webmvc, but spring-web only?

@laijianbin
Copy link
Contributor Author

Oh, In dependency management. I make a mistake

@laijianbin laijianbin closed this Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants