Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-940] move float type test case from demo to integration-test #931

Merged
merged 1 commit into from Oct 10, 2018
Merged

[SCB-940] move float type test case from demo to integration-test #931

merged 1 commit into from Oct 10, 2018

Conversation

heyile
Copy link
Contributor

@heyile heyile commented Sep 28, 2018

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@liubao68
Copy link
Contributor

This PR conflicts with previous merged one. Please rebase and fix it.

@heyile
Copy link
Contributor Author

heyile commented Sep 29, 2018

This PR conflicts with previous merged one. Please rebase and fix it.

ok, i will fix it soon

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 86.286% when pulling 402ed43 on heyile:it-float into 6aadae0 on apache:master.

@liubao68 liubao68 merged commit 7fca502 into apache:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants