[SCB-942]Choose the highest priority from all implementation classes #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wujimin
reviewed
Sep 30, 2018
| @@ -149,7 +149,7 @@ private SPIServiceUtils() { | |||
| List<T> services = getOrLoadSortedService(serviceType); | |||
| return (IMPL) services | |||
| .stream() | |||
| .filter(service -> service.getClass().equals(implType)) | |||
| .filter(service -> implType.isAssignableFrom(service.getClass())) | |||
There was a problem hiding this comment.
design purpose is equal
why do this change?
There was a problem hiding this comment.
I have updated the JIRA status. This PR is not valid. Please close it.
|
closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.