[SCB-967] Support configed IP send request #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wujimin
reviewed
Oct 17, 2018
| @@ -61,6 +66,8 @@ | |||
| public class LoadbalanceHandler implements Handler { | |||
| public static final String CONTEXT_KEY_SERVER_LIST = "x-context-server-list"; | |||
|
|
|||
| public static final String SERVICECOMB_SERVER_ENDPOINT = "servicecomb-server-endpoint"; | |||
There was a problem hiding this comment.
use shorter name?
eg: scb-endpoint
wujimin
reviewed
Oct 17, 2018
| @@ -167,6 +175,17 @@ private void preCheck() { | |||
|
|
|||
| @Override | |||
| public void handle(Invocation invocation, AsyncResponse asyncResp) throws Exception { | |||
| String endpointUri = invocation.getLocalContext(SERVICECOMB_SERVER_ENDPOINT); | |||
| if (endpointUri != null) { | |||
| boolean isRest = endpointUri.startsWith("rest://"); | |||
There was a problem hiding this comment.
why need to limit to rest?
There was a problem hiding this comment.
support all transport,done
wujimin
reviewed
Oct 18, 2018
| @@ -167,6 +176,23 @@ private void preCheck() { | |||
|
|
|||
| @Override | |||
| public void handle(Invocation invocation, AsyncResponse asyncResp) throws Exception { | |||
| String endpointUri = invocation.getLocalContext(SERVICECOMB_SERVER_ENDPOINT); | |||
There was a problem hiding this comment.
1.sorry, i forgot a requirement:
need a configuration, default to disable this feature
2.extrace the new logic to a method
wujimin
reviewed
Oct 18, 2018
| @@ -167,6 +176,23 @@ private void preCheck() { | |||
|
|
|||
| @Override | |||
| public void handle(Invocation invocation, AsyncResponse asyncResp) throws Exception { | |||
| String endpointUri = invocation.getLocalContext(SERVICECOMB_SERVER_ENDPOINT); | |||
| if (endpointUri != null) { | |||
| String endpointRule = "[a-z]+://.+"; | |||
There was a problem hiding this comment.
URI will check this automatically?
There was a problem hiding this comment.
yes, delete this, and have test in ut
wujimin
reviewed
Oct 18, 2018
| "the endpoint's format of the configuration is incorrect, e.g rest://127.0.0.1:8080"); | ||
| } | ||
| URI formatUri = new URI(endpointUri); | ||
| Transport transport = CseContext.getInstance().getTransportManager().findTransport(formatUri.getScheme()); |
There was a problem hiding this comment.
do not use CseContext anymore, change to ScbEngine
liubao68
reviewed
Oct 19, 2018
| public static final String SERVICECOMB_SERVER_ENDPOINT = "scb-endpoint"; | ||
|
|
||
| public static final boolean supportConfigEndpoint = | ||
| DynamicPropertyFactory.getInstance().getBooleanProperty("servicecomb.configEndpoint.enabled", false).get(); |
There was a problem hiding this comment.
Maybe we can use: servicecomb.loadbalance.userDefinedEndpoint.enabled
wujimin
approved these changes
Oct 19, 2018
liubao68
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.