Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-164] reconnect on crash #110

Merged
merged 6 commits into from Jan 11, 2018
Merged

[SCB-164] reconnect on crash #110

merged 6 commits into from Jan 11, 2018

Conversation

seanyinx
Copy link
Member

@seanyinx seanyinx commented Jan 9, 2018

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@seanyinx
Copy link
Member Author

seanyinx commented Jan 9, 2018

this PR is on top of #107

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 94.878% when pulling e7cf7e3 on SCB-164_reconnect_on_crash into 3c166ad on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 95.034% when pulling 88cebbd on SCB-164_reconnect_on_crash into 3c166ad on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 95.189% when pulling b349c19 on SCB-164_reconnect_on_crash into 3c166ad on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 95.143% when pulling 40ca544 on SCB-164_reconnect_on_crash into b93e795 on master.

Signed-off-by: seanyinx <sean.yin@huawei.com>
…tion

Signed-off-by: seanyinx <sean.yin@huawei.com>
Signed-off-by: seanyinx <sean.yin@huawei.com>
Signed-off-by: seanyinx <sean.yin@huawei.com>
Signed-off-by: seanyinx <sean.yin@huawei.com>
Signed-off-by: seanyinx <sean.yin@huawei.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 95.041% when pulling 7021159 on SCB-164_reconnect_on_crash into 367b1cc on master.

@seanyinx seanyinx merged commit d2da5e1 into master Jan 11, 2018
@seanyinx seanyinx deleted the SCB-164_reconnect_on_crash branch January 11, 2018 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants