SCB-817, SCB-818 TCC Omega side implemenation #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
WillemJiang
commented
Aug 28, 2018
WillemJiang
commented
- Updated the TCC protocol for CoordinatedEvent
- Update the omega transactions code
- Implemented the TccEventServie of grpc
cherrylzhao
reviewed
Aug 28, 2018
| } | ||
|
|
||
| @Override | ||
| public AlphaResponse coordinate(CoordinatedEvent coordinatedEvent) { |
There was a problem hiding this comment.
I can't understand coordinate method mean, when sending transactionEndEvent, alpha will send the cordinateCommand to omega instance asynchronous.
it is why onConnect method has a stream observer.
There was a problem hiding this comment.
It means alpha need to get the execution result of the coordinatedCommand. This process can be asynchronized.
There was a problem hiding this comment.
when received the coordinate feedback message, how alpha handle it，or just persistence the result.
There was a problem hiding this comment.
Alpha just need to persistent the event for management usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.