Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-915:saga alpha event scanner optimization #311

Closed
wants to merge 2 commits into from

Conversation

oliugian
Copy link
Contributor

omega do not send every try event to alpha.omega do it's try logic by itself.

omega do not send every try event to alpha.omega do it's try logic by itself.
Copy link
Member

@WillemJiang WillemJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliugian Did you run the accept test?
I'm not sure why did you delete the forward recovery test code?
BTW, I think we need to avoid the infinite loop of retry (-1) by default.

@oliugian
Copy link
Contributor Author

All tests have been successful
The functionality of ForwardRecovery has been incorporated into defaultRecovery, so delete it and its test code. There is a test code equivalent to ForwardRecover in TransactionAspectTest.
(-1) means infinite retry, but it can also be interrupted, throwing an InterruptedException, which is consistent with the logic in the previous ForwardRecovery

@oliugian oliugian closed this Oct 8, 2018
@oliugian oliugian reopened this Oct 8, 2018
@oliugian
Copy link
Contributor Author

oliugian commented Oct 8, 2018

ignore it

@oliugian oliugian closed this Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants