Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker hub 中的service center 镜像说明需要优化 #424

Open
liweiv opened this issue Aug 21, 2018 · 3 comments
Open

Docker hub 中的service center 镜像说明需要优化 #424

liweiv opened this issue Aug 21, 2018 · 3 comments
Assignees

Comments

@liweiv
Copy link

liweiv commented Aug 21, 2018

  1. Dockerfile 链接 404
    见后面附图
  2. 建议在docherhub 镜像说明文字中将传入的环境变量说明一下,方便用户在不看源码的情况下将etcd集群地址传入,便于基于容器部署SC.
  3. scfrontend docker镜像建议 同上

附图:
image
image

@liweiv
Copy link
Author

liweiv commented Aug 21, 2018

SC ENV : BACKEND_ADDRESS for etcd server list
scfrontend ENV: BACKEND_ADDRESS for sc http API

变量名建议区分一下,部署的时候容器搞混淆。

@asifdxtreme
Copy link
Member

@veily Thanks for pointing out this issue, recently there were some changes in the build script so the Dockerfile was moved.

I have updated the link in the docker hub page, and for the issue 2 & 3 we will work on it and provide the fix in coming release, we will be more than happy if you are willing to submit the fix for this :)

@little-cui
Copy link
Member

关于变了命名容易被混淆问题已经提PR,请检视

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants