SCB-491 Fix the broken links for China Region #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
=======================================
Coverage 69.95% 69.95%
=======================================
Files 17 17
Lines 3418 3418
=======================================
Hits 2391 2391
Misses 863 863
Partials 164 164
Continue to review full report at Codecov.
|
surelovemeng
suggested changes
May 13, 2018
wujimin
reviewed
May 15, 2018
|
|
||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/js-yaml/3.11.0/js-yaml.min.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/yamljs/0.1.5/yaml.js"></script> | ||
| <script src="https://cdn.rawgit.com/asifdxtreme/angular-swagger-ui/565ed3ea/dist/scripts/modules/swagger-yaml-parser.min.js"></script> | ||
| <script src="https://rawcdn.githack.com/asifdxtreme/angular-swagger-ui/master/dist/scripts/modules/swagger-yaml-parser.min.js"></script> |
There was a problem hiding this comment.
the cdn server is not the personal one, the project has been forked in my own local, I will try to push it upstream to angula-swagger-ui, till then sc can use my fork with public cdn server
little-cui
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.go buildgo testgo fmtgo vetto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.